chore(rich-text-editor)!: Rename value to defaultValue #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ae623f7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
To conform to React naming convention for form control props.
Uncontrolled form fields take a `defaultValue` to indicate that
changes to this prop's value will not update the mounted component.
Rather, the component manages its current value as internal state,
and notifies subscribers via onChange when it changes.
Consumers will need to update their code to the new prop name. E.g. before:
```jsx
<RichTextEditor value={…}>
```
and after:
```jsx
<RichTextEditor defaultValue={…}>
```
sentience
force-pushed
the
rich-text-editor-rename-value-prop-to-defaultvalue
branch
from
2f33c6a
to
ae623f7
Compare
dougmacknz
approved these changes
Sep 12, 2023
dougmacknz
deleted the
rich-text-editor-rename-value-prop-to-defaultvalue
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
To conform to React naming convention for form control props.
Uncontrolled form fields take a
defaultValueto indicate thatchanges to this prop's value will not update the mounted component.
Rather, the component manages its current value as internal state,
and notifies subscribers via
onChangewhen it changes.https://cultureamp.atlassian.net/browse/SR2-721
What
Consumers will need to update their code to the new prop name. E.g. before:
and after: